Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: New WASM implementation #19

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Draft: New WASM implementation #19

wants to merge 3 commits into from

Conversation

jgraef
Copy link
Owner

@jgraef jgraef commented Jul 9, 2024

This implementation spawns a local task, which drives the websocket connection. The WebSocket struct that the user gets only contains channels to communicate with the task. This way the WebSocket is Send.

@jgraef jgraef added the enhancement New feature or request label Jul 9, 2024
@jgraef jgraef force-pushed the wasm-rewrite branch 2 times, most recently from 3e75043 to 1a059a9 Compare July 9, 2024 05:54
@jgraef jgraef marked this pull request as draft July 9, 2024 05:55
@jgraef jgraef mentioned this pull request Dec 23, 2024
Closed
@jgraef
Copy link
Owner Author

jgraef commented Dec 23, 2024

The new wasm-implementation seems to work. I added an assertion that WebSocket: Send + Sync, but this fails for native, as hyper::Upgraded is not Sync. Works for wasm now though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jgraef